[DMS-1154] Make Smoke Test Happy#519
Merged
Merged
Conversation
Test Results 1 files 460 suites 12m 8s ⏱️ Results for commit cfe4c77. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
Updates the OpenAPI generation for Change Query tracked-change endpoints so their operationId values follow the deletes... / keyChanges... naming pattern, and refreshes the authoritative OpenAPI artifacts/tests to match (to address failing smoke/integration checks).
Changes:
- Adjust tracked-change
operationIdgeneration fromget...Deletes/get...KeyChangestodeletes.../keyChanges.... - Update the unit test to assert the new
operationIdvalues for/deletesand/keyChangesendpoints. - Update the v7_2 and v7_3 authoritative OpenAPI JSON artifacts to reflect the new tracked-change operationIds.
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/metaed-plugin-edfi-api-schema/src/enhancer/OpenApiSpecificationEnhancerBase.ts | Changes tracked-change operationId naming to deletes... / keyChanges.... |
| packages/metaed-plugin-edfi-api-schema/test/enhancer/OpenApiResourceFragmentEnhancer.test.ts | Updates expectations to validate the new tracked-change operationIds. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/tpdm-api-schema-authoritative.json | Updates tracked-change operationIds in the TPDM authoritative OpenAPI artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/sample-api-schema-authoritative.json | Updates tracked-change operationIds in the Sample authoritative OpenAPI artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/homograph-api-schema-authoritative.json | Updates tracked-change operationIds in the Homograph authoritative OpenAPI artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/ds-6.1-sample-api-schema-authoritative.json | Updates tracked-change operationIds for DS 6.1 Sample artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/ds-6.1-homograph-api-schema-authoritative.json | Updates tracked-change operationIds for DS 6.1 Homograph artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/ds-6.0-sample-api-schema-authoritative.json | Updates tracked-change operationIds for DS 6.0 Sample artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_3/ds-6.0-homograph-api-schema-authoritative.json | Updates tracked-change operationIds for DS 6.0 Homograph artifact. |
| packages/metaed-plugin-edfi-api-schema/test/integration/artifact/v7_2/tpdm-api-schema-authoritative.json | Updates tracked-change operationIds in the v7_2 TPDM authoritative OpenAPI artifact. |
simpat-adam
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two line change for operationIds named like the smoke test wants.